Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Add rotation, strokeStart, and strokeEnd key paths. #19

Merged
merged 2 commits into from
Nov 2, 2017
Merged

Add rotation, strokeStart, and strokeEnd key paths. #19

merged 2 commits into from
Nov 2, 2017

Conversation

jverkoey
Copy link
Contributor

@jverkoey jverkoey commented Nov 2, 2017 •
edited
Loading

These will be used in the MDC iOS activity indicator motion spec.

@jverkoey jverkoey requested a review from romoore November 2, 2017 17:32
romoore
romoore approved these changes Nov 2, 2017
View reviewed changes
Copy link

@romoore romoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any functional Unit Tests?

@jverkoey
Copy link
Contributor Author

jverkoey commented Nov 2, 2017

None for the key paths. We just have one test ensuring that the key path APIs are exported properly in Swift.

@jverkoey jverkoey merged commit ccdffd5 into develop Nov 2, 2017
@jverkoey jverkoey deleted the rotation branch November 2, 2017 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@romoore romoore romoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jverkoey @romoore