Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Add public/private marks to the animator implementation. #70

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Conversation

jverkoey
Copy link
Contributor

This will help organize some upcoming work on the animator's implementation.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This will help organize some upcoming work on the animator's implementation.
@jverkoey jverkoey requested review from samnm and romoore November 29, 2017 14:56
Copy link

@samnm samnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually put private stuff at the bottom of the file, but I don't know if either is preferred.

@romoore
Copy link

romoore commented Nov 29, 2017

+1 to private at the bottom. I'm assuming all the methods that follow, including animateWithTiming:toLayer:withValues: is private as well?
I just saw the #public afterward. I think it's clearest to put the private at the bottom. Then anything no explicitly marked (-init?) can be assumed public.

@jverkoey jverkoey merged commit 71d22e2 into develop Nov 29, 2017
@jverkoey jverkoey deleted the pubpriv branch November 29, 2017 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants