Options in select element still highlighted after unselecting it.

[Singha360]

[DanielRuf]

Can be reproduced on https://materializecss.github.io/materialize/select.html

It seems the active class is not removed.

The issue does not exist on https://materializecss.com/select.html
One of the commits that is not in the used version there and that might be relevant is c0da340#diff-f23639ab50ee01de087486418e0e652284a0a5e6d05cc0698a6e85521bb46a38

At least I think so.

Maybe someone can do a git bisect:

git bisect start
git bisect good v1.0.0
git bisect bad v1.1.0-alpha
...
git bisect bad/good

[DanielRuf]

@materializecss/members

[bugy]

I think it was broken here:
#98

After I reverted the changes in dropdown.js locally, it worked fine for me

@ChildishGiant

Another problem which I see now, is that the list elements are not focused anymore. document.activeElement always returns <ul> element, instead of <li>

[DanielRuf]

Ah, that makes sense as it uses the dropdown component.

I think we should try to do at least one review per PR in the future =)

[ChildishGiant]

I'm on holiday right now but will take a look at patching it 😅 Does look like I broke it, but this is what alphas are for 😉

[DanielRuf]

Does look like I broke it, but this is what alphas are for 😉

Exactly =)

I'm on holiday right now but will take a look at patching it 😅

No hurry, enjoy your holiday =)