-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: TimePicker is completely broken #476
Comments
fix TimePicker component
Work around:
|
As per PR #486 I don't see any advantage on defining the input fields as buttons, since they should be accessible with keyboard input aligned to the international standards of web accessibility, the implementation should make gathering and recording the results as simple as possible. Reducing the user input fields to buttons would reduce the exposure to the accessibility API and should be considered invalid. This affects people who rely on keyboard control. I've also tested the timepicker functionality on Materialize v2.1.1 and am not experiencing the issue as described in your subject, as selected time is rendered correctly in the hour and minute input fields as in the base input field. I do notice some quirks in the design as margins and paddings do not align with the Material standards, specifically on the mobile version. Regarding this mobile alignment issue I'm experiencing, I applied some quick fixes within the browser inspector and applied them to a CodePen example |
Just came across additional issues with the Timepicker component:
Currently looking into fixing the styling bug with light theme, implementing additional functionality for accessibility and tabbable enhancements |
Before submitting...
Context
When you click on the TimePicker on the documentation page (or on a local install copy of the last release), the pop-up open, but no time is being displayed when selected, some items like the AM / PM move round, and number are there, but they are not the right color, and too big for the box. It just all over the place.
https://materializeweb.com/pickers.html
Current Behavior
https://materializeweb.com/pickers.html
TimePicker open but displayed data is wrong, and interaction doesn't work like it should
Expected behavior
TimePicker to popup, you select a hour and minutes and it display on the left.
Possible Solutions or Causes
No response
Steps to reproduce
Your Environment
The text was updated successfully, but these errors were encountered: