Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #476 TimePicker is completely broken #486

Open
wants to merge 1 commit into
base: v2-dev
Choose a base branch
from
Open

fix: #476 TimePicker is completely broken #486

wants to merge 1 commit into from

Conversation

IvanPostu
Copy link
Member

@IvanPostu IvanPostu commented Jun 23, 2024 •
edited
Loading

fixes #476
fix TimePicker component

Proposed changes

Screenshots (if appropriate) or codepen:

demo_with_fix_and_tab_click.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io wuda-io changed the base branch from main to v2-dev July 7, 2024 20:59
@IvanPostu IvanPostu requested a review from wuda-io August 31, 2024 20:12
@IvanPostu IvanPostu self-assigned this Sep 16, 2024
@gselderslaghs gselderslaghs mentioned this pull request Oct 15, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuda-io wuda-io Awaiting requested review from wuda-io

At least 1 approving review is required to merge this pull request.

Assignees

@IvanPostu IvanPostu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TimePicker is completely broken
1 participant
@IvanPostu