Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add permission to execute commit-msg hook #332

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: add permission to execute commit-msg hook #332

merged 1 commit into from
Feb 8, 2023

Conversation

wuda-io
Copy link
Member

@wuda-io wuda-io commented Feb 8, 2023

Proposed changes

The husky hook did not work under ubuntu. I found the solution here:
https://stackoverflow.com/questions/8598639/why-is-my-git-pre-commit-hook-not-executable-by-default

Also found out that git saves the permissions of the files too, so I
changed the permission of the commit-msg file to work under linux systems.
chmod ug+x .husky/commit-msg

Also tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io wuda-io mentioned this pull request Feb 8, 2023
8 tasks
@wuda-io wuda-io merged commit dcd64a8 into materializecss:main Feb 8, 2023
@wuda-io wuda-io deleted the fix-husky-hook-permissions branch February 8, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant