Restore form functions #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Exposed "Forms" class to global namespace (M); - Added docs to "Forms::textareaAutoResize".
- Updated usage sample of "Forms::textareaAutoResize":
- Updated explanation (why and when to use it);
- Updated sample so as to remove jQuery syntax.
- Implemented test for textarea resizing feature:
- Updated HTML file (forms);
- Update test suite (JS)
mauromascarenhas
force-pushed
the
restore-form-functions
branch
from
c460a76
to
d0ca109
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit aims to restore "textareaAutoResize" method to the global scope and, therefore, should fix #362.
It has been exposed a little bit differently from v1.x, since it is no longer available as "
M.textareaAutoResize", butM.Forms.textareaAutoResize, but it should not be an issue, since the docs have also been updated 😄.Additional contributions:
Types of changes
Checklist: