Replacement for standard search function in autocomplete #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The current implementation of "onSearch" callback considers every option element when filtering, which causes undesired options to be displayed for autocompletion (see attached screenshots).
This PR aims to replace the current standard search function that should consider only the "id" and "text" attributes, if available, when filtering the given options.
Summary:
Screenshots (if appropriate) or codepen:
Current behaviour
It displays "google" as a option, even though the word does not have an "a" on its spelling (it is possible to reproduce it in the current version of the docs 😞).
Autocomplete with new "standard search" implementation
Types of changes
Checklist: