Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textarea padding #391

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

mauromascarenhas
Copy link

Proposed changes

Fix textarea padding which is currently not being inherited from "default input styles".

The textarea content is being currently overlaped by its label when not active and zero-padded in every context (focused/not focused).

Summary:

  • Fixed stylesheet rules (padding in materialize-texarea class);
  • Added new sample for textarea with custom placeholder;
  • Added placeholder for textarea samples (enable floating label).

Screenshots (if appropriate) or codepen:

Current behaviour

Focused:
Focused textarea with content

Not focused:
Textarea with content, but without focus

New behaviour

Focused:
Focused textarea with content

Not focused:
Textarea with content, but without focus

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Fixed textarea padding.
- Added placeholders for textarea samples (enable floating labels);
- Added new sample for textarea with custom placeholder.
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuda-io wuda-io merged commit f613891 into materializecss:v2-dev Jul 12, 2023
@wuda-io wuda-io mentioned this pull request Jul 12, 2023
@mauromascarenhas mauromascarenhas deleted the textarea-fix branch July 12, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants