Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toast not shows text when classes defined #435

Merged
merged 1 commit into from
Nov 5, 2023
Merged

fix: toast not shows text when classes defined #435

merged 1 commit into from
Nov 5, 2023

Conversation

danice
Copy link

@danice danice commented Nov 4, 2023

Types of changes

Small fix to toast

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danice danice marked this pull request as ready for review November 4, 2023 08:21
@danice danice mentioned this pull request Nov 4, 2023
Closed
3 tasks
mauromascarenhas
mauromascarenhas approved these changes Nov 5, 2023
View reviewed changes
Copy link

@mauromascarenhas mauromascarenhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauromascarenhas mauromascarenhas merged commit 6810107 into materializecss:v2-dev Nov 5, 2023
2 checks passed
@danice danice mentioned this pull request Dec 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromascarenhas mauromascarenhas mauromascarenhas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danice @mauromascarenhas