Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update select.html from "var" to "const" #464

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

melissayr
Copy link

Changed from "var" to "const" in line 157 und 162. Var ist outdated for Javascript const variables.

Proposed changes

In current JavaScript, only const is used to create const variables. Var is outdated. Maybe you can change all var s into const for example in "Forms -> Select -> Initialization" or "Forms -> Select -> Methods".

Screenshots (if appropriate) or codepen:

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • [x ] I have read the CONTRIBUTING document.
  • [x ] My commit messages follows the conventional commit format
  • [ x] My change requires a change to the documentation, and updated it accordingly.
  • [ x] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

wuda-io and others added 7 commits December 19, 2023 02:00
this was causing issue: failed to resolve entry for package "@materializecss/materialize materializecss#455
chore: do not include module section in package
very small fix for tabs: check for null content
Changed from "var" to "const" in line 157 und 162. Var ist outdated for Javascript const variables.
@wuda-io
Copy link
Member

wuda-io commented Mar 8, 2024

Hi, thanks for your contribution. Please use commitlint format next time in the commit messages as suggested by @ChildishGiant. For example "docs: change var to const". Unfortunately the files you have changed have no effect on the documentation and have to be moved to materialize-docs. The PR will be added nevertheless.

@wuda-io wuda-io changed the base branch from main to v2-dev March 8, 2024 19:10
@wuda-io wuda-io merged commit 3f978c6 into materializecss:v2-dev Mar 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants