Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: class="active" non-accordion collapsible not opening by default #465

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

warrenspe
Copy link

fix bug causing collapsible to not auto open

  • Can't exactly explain why it was doing this, but in my development today I noticed that some of my non-accordion collapsibles weren't having their li's with class="active" set on them opening by default. Played around with the code a bit and found that putting these brackets back seemed to resolve it, so here we are

Proposed changes

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

fix bug causing collapsible to not auto open

 - Can't exactly explain why it was doing this, but in my development
  today I noticed that some of my non-accordion collapsibles weren't having
  their li's with class="active" set on them opening by default.
  Played around with the code a bit and found that putting these brackets back
  seemed to resolve it, so here we are
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I dont know if the else is then used for the second if clause or for the first.
Have not tested, but then it is definetaly clear.

@wuda-io wuda-io merged commit 34aeaf3 into materializecss:v2-dev Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants