Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix/enhancement) Datepicker date type #230 #517

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

gselderslaghs
Copy link
Member

Proposed changes

Implemented HTML5 input date field support, making use of the input date field would enhance accessibility and follows the RFC 3339 specification

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gselderslaghs gselderslaghs changed the title Datepicker date type (fix/enhancement) Datepicker date type #230 Oct 23, 2024
@gselderslaghs gselderslaghs changed the base branch from main to v2-dev October 30, 2024 10:31
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the data-date only for displaying the information? I think we can merge it. Thanks!

@wuda-io wuda-io merged commit 4899308 into materializecss:v2-dev Nov 6, 2024
1 check passed
@gselderslaghs
Copy link
Member Author

LGTM. Is the data-date only for displaying the information? I think we can merge it. Thanks!

@wuda-io, the data-date attribute is used to store the date string in the format defined by options.format and is visually being displayed to the end-user while the value is set in format following the RFC 3339 specification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants