Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/improvement(Chips) - Input as option #529

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

gselderslaghs
Copy link
Member

@gselderslaghs gselderslaghs commented Nov 9, 2024

Proposed changes

Enhancement proposal as described in #527

  • Allow building up the chips container without constructing the input field, as result the grid styling would always be applied
  • Implement the rendering of the input element as option within the Chips component

Todo:

  • Update documentation since Chips component is not necessarily a subcomponent within forms, but should be available as standalone component or as a form component if this enhancement get's approved

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…actored constructor, moved input field functional method invocations to setupInput method (materializecss#527)
…focus and close triggers based on allowUserInput option;
… test specification; Refactored existing Chips component test specification according to new implemented allowUserInput option
@gselderslaghs gselderslaghs changed the base branch from main to v2-dev November 9, 2024 19:34
Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I try to update the docs soon. Then we can do the merge

wuda-io added a commit to materializecss/materialize-docs that referenced this pull request Dec 16, 2024
@wuda-io wuda-io merged commit d0d4efe into materializecss:v2-dev Dec 16, 2024
1 check passed
@gselderslaghs gselderslaghs changed the title fix/improvement(Chips) - Input option (proof-of-concept) fix/improvement(Chips) - Input as option Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants