Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(Collapsible) additional styling for leading badge in coll… #545

Merged

Conversation

gselderslaghs
Copy link
Member

@gselderslaghs gselderslaghs commented Dec 8, 2024

Proposed changes

Implemented leading badge in Collapsible component

  • Implemented the class "leading": this class will place the badge at the most left position in the collapsible element

Codepen:

Codepen example

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation
  • My change requires a change to the documentation and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@wuda-io wuda-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css variables for the margins would be cool. I don't know if there are specs from M3 but nevertheless, good work!

@wuda-io wuda-io merged commit 58994c9 into materializecss:v2-dev Dec 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants