enhancement(Datepicker) date range #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplemented input change handler for end date input; Fix issue where formatted date was not rendered correctly on date type input; Fix existing spec tests materializecss#360
…ange modal se lected option input validation
…d date input field creation on initialization
gselderslaghs
changed the title
wuda-io
previously approved these changes
Dec 16, 2024
gselderslaghs
dismissed
wuda-io’s stale review
The merge-base changed after approval.
|
I will merge it in first, and then change the modal in #556 because date and timepicker depend on the modal component. We should change it to the Popover API since it is widely available in browsers now. https://caniuse.com/?search=popover |
wuda-io
previously approved these changes
Dec 16, 2024
gselderslaghs
dismissed
wuda-io’s stale review
The merge-base changed after approval.
wuda-io
previously approved these changes
Dec 16, 2024
|
As Ive been working on the #360 multi date select, I've found some additional issue's that I'm about to commit soon regarding date range select |
…day or multi day date selection; Implemented setDateFromInput for logical navigation within the calendar by mouse/keypress interaction on input change, fixes issue where calendar only navigated to latest changed field; Refactored handleCalendarClick, split up single date click and date range click for the sake of code readability and simplicity; Updated JSDoc, removed unused parameter; Deprecated _setToStartOfDay (function has no effect); materializecss#360
|
Ok, implemented additional refactoring based on my previous issues concerns, think this PR is ready for review Changelog as of the latest commits
|
gselderslaghs
dismissed
wuda-io’s stale review
The merge-base changed after approval.
wuda-io
approved these changes
Dec 17, 2024
wuda-io
previously approved these changes
Dec 17, 2024
gselderslaghs
dismissed
wuda-io’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implemented date range select functionality as per pull-request #360
dateRange: trueis providedstyling of the in-range items needs to be addressed, propose create this in a new issue since the global layout of the datepicker is outdated: currently still follows the M2 guidelines
Types of changes
Checklist: