-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conda-forge to Circle CI and include conda-forge installation instructions #521
Conversation
I guess |
After checking with Linux and Windows, Linux works fine but windows installation still gives RandomizedPCA error. |
Relax the testing standard for polynomial degree since all degrees give similar results and the cross validation is stochastic. Currently, it hasn't been determined how to make it deterministic even with seeds.
You're still getting the same error from #520. I'll answer in that issue. |
@beyucel @auag92 @SvenPVoigt feel free to review this now |
I just checked it again. It was a local problem. There is no problem with the Windows installation. I checked all notebooks (with conda-Windows). |
Looks like the grid search parameter (in the fibers notebook) has some random variability to it. Is there any guarantee the check will pass with the new assertion |
We don't want any variability ideally, but I haven't figured out how to seed it.
Those are the only choices we're trying (from 1 to 3)! The poly degree doesn't have much influence.
We shouldn't have randomness that isn't seeded as part of the tests. Just have to live with it for now unless we can figure out how to fix it. |
Alright. Thanks for the answer!
Great, the test is guaranteed to pass then. I will approve. |
If you can figure out a way to make the example deterministic then I buy you a beer. |
No description provided.