Excise openff dependency from OpenMM testing #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janosh would you mind taking a look? |
janosh
reviewed
Sep 26, 2024
src/atomate2/openmm/utils.py
Outdated
| from emmet.core.openmm import OpenMMTaskDocument | ||
|
|
||
| with suppress(ImportError): |
There was a problem hiding this comment.
TYPE_CHECKING is always False at run time so no need to suppress errors here. also, suppress is quite slow compared to try/except so would usually opt for that
There was a problem hiding this comment.
I initially did try/except but it was caught by the linter. should I override then? nvm, understood ty
There was a problem hiding this comment.
yes, we should ignore that ruff rule that recommends contextlib.suppress. bad rule imo
Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com>
|
All fixed, thanks for review @janosh |
janosh
added
testing
auto-merge was automatically disabled
September 26, 2024 20:32
Head branch was pushed to by a user without write access
janosh
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
looks great! 👍 thanks for the quick turnaround on #923 (comment) @orionarcher
janosh
changed the title
hrushikesh-s
pushed a commit
to hrushikesh-s/atomate2
that referenced
this pull request
Nov 16, 2024
* Excise openff dependency from openmm testing * Remove commmented out code * Update src/atomate2/openmm/jobs/base.py Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com> * Respond to Yanosh PR and fix type of OpenMM Flow * Fix typo, lint * Add dataclass tag where needed --------- Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the openff dependency from the openmm test suite. This conflict originally arose in PR #923.