-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dscribe
an optional dependency
#270
Conversation
Thanks @janosh, added an extra guard statement to ensure |
Otherwise if you're happy with this, I can merge. Tagging issue #261 here too. |
Go ahead! |
Just double-checking, I think |
I was confused by the fact |
Yes--worth checking! I was premising this discussion on the assumption that you would like to install crystal toolkit with server options, but that dependency solving is currently broken. Right now, the default install (without any extras) is really just for use in Jupyter. The install with
|
The question, perhaps, is if the installation is failing even when not installing the |
I wasn't specifying any extras so... yes, I think. |
Ok, I'll have to take a closer look. My best guess is that this is happening because of a dependency on |
I think we can still merge this in regardless, because loosening the dependency is still a good idea |
So I think |
…ptional-dep Make `dscribe` an optional dependency
Motivation: This in turn makes
numba
installation optional which caused issues (see #228 (comment)).