Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AliasingErrorHandlerTest modifying test files #301

Merged
merged 5 commits into from
Nov 5, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 5, 2023

No description provided.

@janosh janosh added tests Test all the things DX Developer experience labels Nov 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (22d1956) 64.86% compared to head (f005598) 64.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   64.86%   64.84%   -0.03%     
==========================================
  Files          51       51              
  Lines        5465     5458       -7     
==========================================
- Hits         3545     3539       -6     
+ Misses       1920     1919       -1     
Files Coverage Δ
custodian/ansible/actions.py 88.67% <ø> (ø)
custodian/vasp/tests/test_handlers.py 100.00% <100.00%> (ø)
custodian/vasp/validators.py 83.82% <100.00%> (ø)
custodian/vasp/jobs.py 49.72% <0.00%> (ø)
custodian/vasp/handlers.py 78.56% <58.06%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosh janosh merged commit e36e48a into master Nov 5, 2023
2 checks passed
@janosh janosh deleted the fix-AliasingErrorHandlerTest-changing-test-files branch November 5, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Developer experience tests Test all the things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants