Handle store error during finalize

[jmmshn]

Handle store Error during finalize

I assume the try/except in finalize is meant to handle situations where the store is already closed.

maggma/src/maggma/core/builder.py

Lines 109 to 118 in f88951d

	def finalize(self):
	"""
	Perform any final clean up.
	"""
	# Close any Mongo connections.
	for store in self.sources + self.targets:
	try:
	store.close()
	except AttributeError:
	continue

However, closing a store:

maggma/src/maggma/stores/mongolike.py

Lines 421 to 426 in f88951d

	def close(self):
	"""Close up all collections."""
	self._collection.database.client.close()
	self._coll = None
	if self.ssh_tunnel is not None:
	self.ssh_tunnel.stop()

can cause a StoreError if it's already closed.

maggma/src/maggma/stores/mongolike.py

Lines 254 to 258 in f88951d

	def _collection(self):
	"""Property referring to underlying pymongo collection."""
	if self._coll is None:
	raise StoreError("Must connect Mongo-like store before attempting to use it")
	return self._coll

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.31%. Comparing base (f88951d) to head (819d187).

Files	Patch %	Lines
src/maggma/core/builder.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files          46       46           
  Lines        3976     3976           
=======================================
  Hits         3233     3233           
  Misses        743      743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rkingsbury]

Thanks @jmmshn !