Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capability to configure query on request #985

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Conversation

yang-ruoxi
Copy link
Member

Summary

Major changes:

  • Added the capability in ReadOnlyResource for it to be able to configure query parameters based on the incoming request header.
  • The added arg is configure_query_on_request which defaults to None.
  • The abstract method configure_query_on_request lives in the HeaderProcessor class, one would rewrite it in any custom header processor, e.g. in emmet-api

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (fd4d610) to head (6dcd244).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
+ Coverage   88.76%   88.83%   +0.06%     
==========================================
  Files          46       46              
  Lines        3979     3985       +6     
==========================================
+ Hits         3532     3540       +8     
+ Misses        447      445       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury
Copy link
Collaborator

Thanks @yang-ruoxi . I generally defer to @munrojm on anything API-related, but I understand he's in transition right now and I'm not sure if he's actively maintaining maggma. I'm happy to merge if you're ready; just let me know.

@yang-ruoxi
Copy link
Member Author

hey @rkingsbury thank you! Going forward, I will be working on the API side of things, and will coordinate with you regarding merging api-related codes.

@yang-ruoxi
Copy link
Member Author

Hi @rkingsbury I think it's good to go!

@rkingsbury rkingsbury merged commit 0bb793c into main Aug 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants