use isinstance grammar for typing

materialsproject · Jul 31, 2024 · 03b546e · 03b546e
1 parent dda75a9
commit 03b546e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/pymatgen/io/vasp/incar_parameters.json b/src/pymatgen/io/vasp/incar_parameters.json
@@ -650,7 +650,7 @@
     "type": "bool"
  },
  "LREAL": {
-   "type": "Union[bool, str]",
+   "type": "(bool, str)",
    "values": [
       false,
       true,

diff --git a/src/pymatgen/io/vasp/inputs.py b/src/pymatgen/io/vasp/inputs.py
@@ -1015,10 +1015,6 @@ def check_params(self) -> None:
         If a tag doesn't exist, calculation will still run, however VASP
         will ignore the tag and set it as default without letting you know.
         """
-        # Need to import Union to support type checking of "LREAL"
-        # TODO: Use "X | Y" after moving to Python 3.10+, see #3958
-        from typing import Union  # noqa: F401
-
         # Load INCAR tag/value check reference file
         with open(os.path.join(module_dir, "incar_parameters.json"), encoding="utf-8") as json_file:
             incar_params = json.loads(json_file.read())