-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for vaspout.h5, improvements to potcar handling #3680
Draft
esoteric-ephemera
wants to merge
32
commits into
materialsproject:master
Choose a base branch
from
esoteric-ephemera:vaspout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
700d255
First pass add functional Vaspout parser
esoteric-ephemera 6231f44
Merge branch 'materialsproject:master' into vaspout
esoteric-ephemera dbea9d8
Add POTCAR spec attrs to standardize spec, add from_spec method to Po…
esoteric-ephemera 31ba296
pre-commit auto-fixes
pre-commit-ci[bot] 4b792ff
fix failing lobster tests
esoteric-ephemera c1fde3c
pre-commit auto-fixes
pre-commit-ci[bot] eef3ee3
Merge branch 'master' into vaspout
esoteric-ephemera 99dfb9a
pre-commit auto-fixes
pre-commit-ci[bot] e107740
Add Vaspout tests, fix method
esoteric-ephemera 6a60d61
pre-commit and fix test names
esoteric-ephemera 2cc49ed
fix remaining linting and mypy errors
esoteric-ephemera 4261948
Merge branch 'master' into vaspout
esoteric-ephemera d6a616b
pre-commit auto-fixes
pre-commit-ci[bot] c3d29d5
Fix python 3.9 support, add charge and magnetization site_properties …
esoteric-ephemera 5a0c985
pre-commit auto-fixes
pre-commit-ci[bot] dd4fceb
Fix projected DOS parsing
esoteric-ephemera bd6792a
linting / typing
esoteric-ephemera aa7c013
remove dunder methods from potcar spec
esoteric-ephemera 68ee0ff
resolve merge conflicts
esoteric-ephemera ee05396
linting
esoteric-ephemera 0bafff1
increase support for auto k point generation
esoteric-ephemera b6427a6
linting
esoteric-ephemera c9475a6
resolve merge conflicts
esoteric-ephemera 1db644d
precommit
esoteric-ephemera b68ae9c
add h5py to ci extra install for testing
esoteric-ephemera 747a950
make vaspout tests optional
esoteric-ephemera 9dac8ca
explicit reason pass to pytest skipif
esoteric-ephemera cb5ad84
Merge branch 'master' into vaspout
esoteric-ephemera ccb57c1
Merge branch 'master' into vaspout
esoteric-ephemera 4cb802b
remove os system call
esoteric-ephemera 641a76f
resolve merge conflicts, fix vaspout file compression
esoteric-ephemera 34d5a34
precommit
esoteric-ephemera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ | |
Oszicar, | ||
Outcar, | ||
Procar, | ||
Vaspout, | ||
Vasprun, | ||
VolumetricData, | ||
Wavecar, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add following parameter and attributes to the class.
dos_kpoints_opt
eigenvalues_kpoints_opt
projectors_kpoints_opt
It will be useful in case of one-shot calculation of bandstructure. Particularly, it is useful while doing HSE calculations (ref), which requires adding the kpoints with fake weights for hartree-fock calculations(ref). One-shot calculations reduces the two step calculations to one-step with two kpoints file, i.e.,
KPOINTS
andKPOINTS_OPT
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll get on this next, will also bring the PR up to date with #3509