Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.9 support #4009
Drop Python 3.9 support #4009
Changes from 12 commits
b66b18e
6044997
8b65cd6
83cc919
a2a1378
4f0b6dc
254db09
bb037ab
ed4434e
e49d468
44b54b2
52c220e
a14c2bb
ae52d59
d1592d1
5001131
7a0fc0f
6f5a274
9e3b647
9fdaede
b6dbf20
6ed060e
30cada6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally, most of these auto-inserted
zip(strict=False)
should be changed tostrict=True
for increased safety. a few cases will rely onstrict=False
for correct behavior though so it's a lot of work to identify which ones need to stay to keep the prior behavior ofstrict=False
. pinging @mkhorton in case he wants to weigh inThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I wouldn't expect people to
zip
two unequal length sequences in most cases and not getting a warning when their lengths don't match (could potentially be more hidden bugs). Might worth opening an issue to track this (this PR is already crazily huge).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to confirm, reading matplotlib/matplotlib#28551 the entire faulty 3.9.1 release was yanked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see https://pypi.org/project/matplotlib/#history: