Use distinct names for artifacts #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janosh The release just failed and I think this should solve it. |
|
thanks @ab5424! 👍 could you also bump the pymatgen/.github/workflows/release.yml Line 39 in 48e7c98 |
|
@janosh Sorry I missed that one, done 👍 |
janosh
added
fix
janosh
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major changes:
upload-artifactswas recently bumped tov4(see Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows #4037). I think that this breaks the release workflow because fromv4upwards they are not allowed to have the same name anymore (see [bug] (v4) Unable to upload to same artifact name from multiple jobs actions/upload-artifact#478). This PR should fix it, according to this suggestionChecklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)