Cleanup codespell
ignore patterns
#4175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup
codespell
ignore patternsCurrently a lot of global ignore patterns are very specific to a certain module (or even one line), there's no good reason to ignore a pattern globally for such cases. Admittedly it will be a balance between convenience (no one want to insert a
# codespell:ignore
tag every line) and correctness (some patterns are very specific to few lines across the code base, but are real typos elsewhere, likelamda/coul
, do note).Changes:
Nd/Te
, or very common for a commonly used module,TITEL
for VASP for example, or our good friendatomate
Follow up
ontop
foradsorption.py
, orcoul
forLAMMPS
)? Currentlycodespell
seems to provide block-level ignore tag but doesn't take a pattern