Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MPRester import and add has_props to query in download notebook #103

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Aug 18, 2022

  • from mp_api import MPRester -> from mp_api.client import MPRester.
  • has_props=[HasProps.charge_density] added to general query to ensure only materials with charge density data are returned.

@munrojm munrojm requested a review from jmmshn August 18, 2022 22:01
@codecov-commenter
Copy link

Codecov Report

Merging #103 (d4608ea) into main (b4b7d6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   79.27%   79.27%           
=======================================
  Files           5        5           
  Lines         304      304           
=======================================
  Hits          241      241           
  Misses         63       63           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jmmshn jmmshn merged commit 3247aa2 into main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants