-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make reading time field editable #270
Conversation
Could you fix the conflicts? It doesn't looks like a trivial change and didn't want to add it 2.1 but now I can take a look for 2.2. |
6bd8581
to
26f78ef
Compare
Ok I reviewed it now, sorry it took long time.
I'm doing some other stuff with the db etc and I'm happy to work on the changes I mentioned. Just let me know if you are okay or if you want to implement them yourself @vbh |
26f78ef
to
f769894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just small mentioned changes
- consider reading time field when calculating fastest and slowest read book
Currently reading time field is only readable, this PR adds a reading time field in the Add/Edit book screen which will be visible only if the status is finished. If reading time is not edited or set then the default logic of reading time (calculated based on start and finish dates) will be used.