Handle secondary and tertiary sorting #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to adjust the sorting adding the logic of the secondary and, in some cases, tertiary sorting. It closes #181
The main logic is that the books are sorted :
This should handle most of the cases, even some edge cases like the comics, when we would need the full release date (we only store the information of the publication year). It obviously fails when the titles are not correctly sortable.
P.S.: this is my very first PR ever, so let me know if I miss something, or I have made something wrong