Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

323 bug the number of editions displayed when choosing a book is wrong #340

Conversation

apobrt
Copy link
Collaborator

@apobrt apobrt commented Sep 28, 2023

Previously, it showed a wrong number of editions for every result. This PR fix this

@apobrt
Copy link
Collaborator Author

apobrt commented Sep 28, 2023

Closes also #180

@mateusz-bak
Copy link
Owner

Hmm I checked and it still displays wrong editions count.

For example try to search "mythos stephen fry" and check editions for the blue book.

@apobrt
Copy link
Collaborator Author

apobrt commented Oct 6, 2023

I found the reason of the mismatch: I show all editions returned by Open Library, but when they are displayed , they are filtered out if they don't have a cover image.

So, for example, "mythos stephen fry", in the fifth result, show correctly 10 results, but only 6 have the cover (see: https://openlibrary.org/books/OL28643252M/Mythos).

So now my doubt is: what we want to show? Only the ones with the covers? Or all of them?
A book without a cover is ugly, but it could be useful to avoid to manually insert all the info (maybe it lacks only the cover).

My proposal is:

  • add a "stock" cover image to every edition that doesn't have one (to make it look better)
  • show every edition (to not lose any valuable edition)

@mateusz-bak
Copy link
Owner

Good finds, I think that showing all of the editions, even without covers makes most sense (I see majority voted the same in the Matrix channel).

On the ones with missing covers - I would go with displaying them as they actually are - so without the covers. And to differentiate we could do title, author and release of the specific edition (as you suggested before).

In the future we need to come up with a system to add covers to books without them.

@mateusz-bak mateusz-bak merged commit 2798cf1 into master Nov 9, 2023
2 checks passed
@mateusz-bak mateusz-bak deleted the 323-bug-the-number-of-editions-displayed-when-choosing-a-book-is-wrong branch November 11, 2023 19:37
@apobrt apobrt self-assigned this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The number of editions displayed when choosing a book is wrong
2 participants