Skip to content

Detect react-native-edge-to-edge and bypass setShouldMimicIOSBehavior #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateusz1913 merged 2 commits into from
Nov 18, 2024
Merged

Detect react-native-edge-to-edge and bypass setShouldMimicIOSBehavior #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b146232
feat: detect react-native-edge-to-edge
zoontek Nov 17, 2024
10adbcb
fix: avoid an useless function call
zoontek Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react-native-avoid-softinput/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@
"build-library": "bob build",
"release-library": "release-it"
},
"dependencies": {
"react-native-is-edge-to-edge": "^1.1.6"
},
"devDependencies": {
"@release-it/conventional-changelog": "8.0.2",
"@types/react": "18.3.12",
Expand Down
11 changes: 9 additions & 2 deletions packages/react-native-avoid-softinput/src/AvoidSoftInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import type { EmitterSubscription } from 'react-native';
import { NativeEventEmitter, Platform } from 'react-native';
import { controlEdgeToEdgeValues, isEdgeToEdge } from 'react-native-is-edge-to-edge';

import module from './AvoidSoftInputModule';
import type { SoftInputAppliedOffsetEventData, SoftInputEasing, SoftInputEventData } from './types';

const EDGE_TO_EDGE = isEdgeToEdge();

const eventEmitter = new NativeEventEmitter(Platform.OS !== 'ios' ? undefined : module);

/**
Expand Down Expand Up @@ -50,8 +53,12 @@ function setShouldMimicIOSBehavior(shouldMimic: boolean) {
if (Platform.OS !== 'android') {
return;
}

module.setShouldMimicIOSBehavior(shouldMimic);
if (__DEV__) {
controlEdgeToEdgeValues({ shouldMimic });
}
if (!EDGE_TO_EDGE) {
module.setShouldMimicIOSBehavior(shouldMimic);
}
}

/**
Expand Down
11 changes: 11 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13100,6 +13100,7 @@ __metadata:
react: "npm:18.3.1"
react-native: "npm:0.76.0"
react-native-builder-bob: "npm:0.30.2"
react-native-is-edge-to-edge: "npm:^1.1.6"
release-it: "npm:17.6.0"
typescript: "npm:5.0.4"
peerDependencies:
Expand Down Expand Up @@ -13155,6 +13156,16 @@ __metadata:
languageName: node
linkType: hard

"react-native-is-edge-to-edge@npm:^1.1.6":
version: 1.1.6
resolution: "react-native-is-edge-to-edge@npm:1.1.6"
peerDependencies:
react: ">=18.2.0"
react-native: ">=0.73.0"
checksum: 10/4e07c1e34c01c8d50fd7c1d0460db06f6f0515197405230386a8ffb950cb724b10743af032310d1384df0a90059bfb8992ba2d93344ce86315315f0493feccc2
languageName: node
linkType: hard

"react-native-reanimated@npm:3.16.1":
version: 3.16.1
resolution: "react-native-reanimated@npm:3.16.1"
Expand Down