Fixes macOS builds (on CI/CD and locally) #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from #170
This PR allows users and CI/CD to process a build successfully on macOS, which is the first step to support Python 3.13.
Jobs have been forced to run on
macos-13, asmacos-13is the last Github-Hosted runner which runs on Intel Macs. This is needed as cross-compiling for x86_64 on Apple Silicon macs is not handled by the ffmpeg build script. This will need to be handled soon, but decided to go for the easy path for now. Building for Apple Silicon on Apple Silicon works flawlessly.Recent XCode releases removed
force_cpusubtype_ALLflag, so a patch was needed forlibvorbis(see: https://trac.macports.org/ticket/68240)Libvpx had a similar issue (on another flag), but they released a new version, therefore a patch was not needed, just a version bump has been performed.
delocateremoveddelocate-fuse, and addeddelocate-merge.delocate-mergedoes not overwrites the source wheel, but creates a new one, with a proper name.