Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Polymorphic serialiser is grouping results by resource type #92

Closed
3 tasks
janders4 opened this issue May 10, 2024 · 0 comments
Closed
3 tasks

[BUG] Polymorphic serialiser is grouping results by resource type #92

janders4 opened this issue May 10, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@janders4
Copy link
Contributor

Describe the bug*

The Polymorphic serialiser is changing the order of results, grouping them by resource type. This causes problems when using the serialiser to perform actions such as searching where the original order of the results represents the strength of the search hit.

To Reproduce*

  1. Implement a polymorphic serialiser
  2. Perform a query that will return multiple resource types
  3. Have your application provide the results to the serialiser not already grouped by resource type

Expected behavior*

The serialiser should honour the order of the resources or provide an option to maintain order

Platform*

  • OS: macOS 14.3.1
  • Browser N/A
  • Version: 1.11.3

* means required.

@janders4 janders4 added the bug Something isn't working label May 10, 2024
@egmacke egmacke assigned egmacke and unassigned jrandolf May 13, 2024
egmacke added a commit to egmacke/ts-japi that referenced this issue May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants