-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(slides) : Added Slide system + finish parsing markdown + presentation mode #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheoleger
requested review from
ByMSRT and
Liv44
and removed request for
ByMSRT
April 9, 2023 16:44
ByMSRT
reviewed
Apr 10, 2023
index.ts
Outdated
Comment on lines
61
to
67
console.log("maximized-app") | ||
win.setFullScreen(false) | ||
}) | ||
|
||
//Set to fullscreen | ||
win.webContents.ipc.on("fullscreen-app", () => { | ||
console.log("fullscreen-app") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 console.log à supprimer
ByMSRT
reviewed
Apr 10, 2023
src/renderer/utils/utils.ts
Outdated
Comment on lines
84
to
91
// return ( | ||
// `<pre class="hljs"><code>${hljs.highlight(lines.join("\n"), { | ||
// language: fileExtension[1] || "", | ||
// ignoreIllegals: true, | ||
// }).value}</code></pre>` | ||
// ) | ||
|
||
// I must use a concatenate string instead of `` because of tabulation and break line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 A supp ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.