Proper response for DMX_START_ADDRESS (get+set) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathertel
added a commit
that referenced
this pull request
Dec 13, 2013
Proper response for DMX_START_ADDRESS (get+set)
|
See my response here @saiteja9429 : |
|
Hi Peter,
How are you?
Can you please share the schematic for your code. So that if there is any
mistake i can check and rectify it.
Thanks & Regards,
Sai Teja
…On Sun, Aug 19, 2018 at 1:00 AM Peter Newman ***@***.***> wrote:
See my response here @saiteja9429 <https://github.com/saiteja9429> :
#7 (comment)
<#7 (comment)>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AdSxJSw2YiHwiLpvm8ddBrvVhaeU0Xy8ks5uSGtNgaJpZM4BTdys>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specs, the PDL must be 0 for E120_SET_COMMAND E120_DMX_START_ADDRESS and 2 for E120_GET_COMMAND E120_DMX_START_ADDRESS.
I noticed that because OLA was complaining; this pull request fixes this.