This repository has been archived by the owner on Dec 9, 2017. It is now read-only.
Add Chakra formula #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mathiasbynens
force-pushed
the
add-chakra
branch
from
3b636ce to
2767a26
Compare
Closed
mathiasbynens
force-pushed
the
add-chakra
branch
3 times, most recently
from
2ce9082 to
a840188
Compare
mathiasbynens
force-pushed
the
add-chakra
branch
from
a840188 to
64c1000
Compare
|
@mathiasbynens sorry for late answer. I've been keeping the chakra formula on homebrew up-to-date. I could send an additional PR here as well. Thanks for this! |
|
Please do! It would be great if this could be part of the Chakra release process. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@obastemur This is what I had in mind. What do you think?
This way, OS X users could install the
chakrabinary by runningbrew install mathiasbynens/ecmascript/chakra.I plan to merge this once
v2.0.0the next version is officially released. Updating the formula when ChakraCore updates is a matter of updating theurlandsha256properties in this file. I’m hoping this could be made part of the ChakraCore release process, or even automated in some way.