Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #109 #141

Closed
wants to merge 5 commits into from
Closed

Fix issue #109 #141

wants to merge 5 commits into from

Conversation

mrhmouse
Copy link

These changes should prevent the placeholder text from becoming the input's value in older versions of Internet Explorer.

@SimenB
Copy link
Contributor

SimenB commented Jul 24, 2013

Thanks for this, it works! I was going crazy trying to debug this stuff.

Please merge!

@bkvirendra
Copy link

This causes the passwords to display in plain-text!

@mrhmouse
Copy link
Author

mrhmouse commented Aug 5, 2013

Can you provide a JSBin or JSFiddle to demonstrate this? That will obviously need to be fixed before merging this!

Edit: Here's a JSBin that creates a password input and calls placeholder on it. I don't see the behavior you're referring to in IE6, but I haven't tried IE7-9.

Edit edit: D'oh, ignore that. I've pulled in the wrong version of the plugin.

@mrhmouse
Copy link
Author

mrhmouse commented Aug 5, 2013

Good catch @bkvirendra! I'll have this fixed shortly.

@JamesMGreene
Copy link

Doubt this will get merged as-is given it has a lot of completely unnecessary coding style changes... not to mention whitespace changes (see files vs. files?w=1).

@JamesMGreene
Copy link

PR #150 seems like a much simpler fix w/o all the unnecessary changes...?

@mrhmouse
Copy link
Author

Aye, it's a bad habit of mine to reformat code as I go (unless there's already a clear and readable style), and to do things like remove unnecessary variables, etc etc.

I agree that it does make the intent of my pull request much harder to read.

@amerikan
Copy link
Collaborator

PR has too many changes. Difficult to see what has changed. I will be closing this. Feel free do a new PR but only make changes that are necessary to fix a bug. Thanks.

@amerikan amerikan closed this Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants