-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #109 #141
Fix issue #109 #141
Conversation
This should fix issue mathiasbynens#109 upstream.
Thanks for this, it works! I was going crazy trying to debug this stuff. Please merge! |
This causes the passwords to display in plain-text! |
Can you provide a JSBin or JSFiddle to demonstrate this? That will obviously need to be fixed before merging this! Edit: Here's a JSBin that creates a Edit edit: D'oh, ignore that. I've pulled in the wrong version of the plugin. |
Good catch @bkvirendra! I'll have this fixed shortly. |
PR #150 seems like a much simpler fix w/o all the unnecessary changes...? |
Aye, it's a bad habit of mine to reformat code as I go (unless there's already a clear and readable style), and to do things like remove unnecessary variables, etc etc. I agree that it does make the intent of my pull request much harder to read. |
PR has too many changes. Difficult to see what has changed. I will be closing this. Feel free do a new PR but only make changes that are necessary to fix a bug. Thanks. |
These changes should prevent the placeholder text from becoming the input's value in older versions of Internet Explorer.