Skip undefined properties for options.json = true; #52
+20
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, many thanks for this awesome package.
Similarily to
JSON.stringify
,jsesc(obj, { json:true })
should skipundefined
properties withinobj
.Side-note: Following discussions on Twitter, I was experimenting moving away from serialize-javascript to
jsesc
to serialize Redux SSR's initial state for GANDI apps such as https://shop.gandi.net when I encounteredjsesc
's behavior regardingundefined
object properties, which differs fromserialize-javascript
's behavior.Awaiting feedback before making final changes.
Fixes #17
Continuation of #18
Thank you for any response.