inline regexpu-fixtures
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/tests.js
Outdated
| const FLAGS_WITHOUT_UNICODE = ' i g m y ig im igm igmy'.split(' '); | ||
| const FLAGS = FLAGS_WITH_UNICODE.concat(FLAGS_WITHOUT_UNICODE); | ||
|
|
||
| const unicodeFixtures = [ |
There was a problem hiding this comment.
Can we still pull it into a separate files, that users can easily replace regexpu-fixtures with regexpu-core/tests/regexpu-fixtures.js?
Merged
nicolo-ribaudo
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation of
regexpu-fixturesis to share the Unicode related regex test cases with other libraries or implementations. Through time it causes maintenance frictions because of the long cycle of adding a new Unicode test cases: add to the repo → publishregexpu-fixtures→ update the package.json here. It might explain why the fixtures of new features, such as property escapes, named groups, etc. are not placed in theregexpu-fixturespackage.In this PR we inline the
regexpu-fixturespackage. I suggest also archive that library. For users ofregexpu-fixtures, they can clone this repo and importunicodeFixturesfrom./tests/fixtures/unicode.js, plus they can now access more fixtures for other Unicode-related regex features.