Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dry module loading #1138

Merged
merged 1 commit into from
Jan 31, 2021
Merged

dry module loading #1138

merged 1 commit into from
Jan 31, 2021

Conversation

rocky
Copy link
Member

@rocky rocky commented Jan 30, 2021

No description provided.

@rocky rocky changed the base branch from master to dryloadmodules January 30, 2021 12:34
@rocky rocky changed the base branch from dryloadmodules to master January 30, 2021 12:35
@rocky rocky force-pushed the drymodules-rocky branch 3 times, most recently from 7ac652f to d70bedb Compare January 30, 2021 14:26
@rocky rocky requested a review from mmatera January 30, 2021 14:41
@rocky
Copy link
Member Author

rocky commented Jan 30, 2021

@mmatera Ok. I think this will work. There seems to be a bug probably uncovered with increased combinatorica testing and possibly old Python 2.7 behavior where you could call reveresed() with a generator.

This has nothing to do with the changes here. Probably I will apply this bug fix to master later on.

@rocky rocky merged commit 12ff672 into master Jan 31, 2021
@rocky rocky mentioned this pull request Jan 31, 2021
@rocky rocky deleted the drymodules-rocky branch February 7, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant