Flatten

[sn6uv]

Implementation of the Flatten algorithm.

[sn6uv]

Might not have a chance to finish this till next week. It works currently if the send argument is a list of length one lists of ints e.g. {{2}, {1}} but I still need to figure out how to e.g. length > 1 sublists e.g. {{1, 2}, {3}} and the other special cases with rules e.g. {2} -> ?

@wolfv if you feel like having a go feel free to submit a PR against this branch sn6uv/Flatten, or alternately you can make your own seperate PR entirely

[wolfv]

Thats great to hear! Time is not an issue for me 👍

[sn6uv]

Length > 1 sublists are done. I still need to do some error handling (e.g. check that the list arg matches the correct format) and a minor cleanup.

@wolfv I'd appreciate your feedback on this. Would you mind testing it with what you have in #252?

[wolfv]

Hi! So far looks great.

One smallish issue I found is this one:

Flatten[a, {2, 1}]

where it crashes int object not iterable. I guess it expects a list, maybe a fix would be to just wrap it?

PS: Flatten[a, {{2, 1}}] == Flatten[a, {2,1}]

[sn6uv]

@wolfv I've applied that fix, thanks.

[sn6uv]

I'm planning to merge this soon. @wolfv are there any more issues you can think of?

[wolfv]

Looks great!