Python3 support #317
Merged
Python3 support #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # TODO fix this ugly hack | ||
| # import codecs | ||
| # writer = codecs.getwriter("utf-8") | ||
| # sys.stdout = writer(sys.stdout) |
There was a problem hiding this comment.
This was an ugly hack to get unicode input working. I'm not sure if there's a better approach.
sn6uv
force-pushed
the
py3
branch
4 times, most recently
from
6881dbe
to
b0f6afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sixmodule (withpython-modernize,python2 -3, and manually)/vs//)interruptingcowas it's no longer maintained (implemented asignalbased interrupt)TODO
ListLinePlot[{{-2, -1}, {-1,-1}}]regressionPerformance
There's a major performance regression that appeared in the benchmarks (needs fix):e.g. 13.1s vs 1.6s on my machine. Affects both py2 and py3.Fixed. It's even slightly faster now, 1.3s.
Other benchmarks seem unchanged, python3 seems about 10% faster on average.