Global system bug

[sn6uv]

Hit this trying to get the `KnotTheory`` package working in Mathics.

Begin["`System`"]

was returning System, not the fully qualified GlobalSystem. It turns out $Contextwas being set first correctly toGlobal`Systemand reset then toSystem``.

@bnjones does this fix look right to you?

[bnjones]

Looks good to me, but what's the effect of not reaching the add_rule on line 258? I can't find anything actually wrong:

In[1]:= $Context = "`test`"
Out[1]= `test`

In[2]:= $Context
Out[2]= Global`test`

In[3]:= Context[`test2]
Out[3]= Global`test`

In[4]:= OwnValues[$Context]
Out[4]= {HoldPattern[$Context] :> Global`test`}

but I don't see where the ownvalues are coming from if we don't add them there?

[bnjones]

Oops, I forgot that set_current_context sets an ownvalue as well, so the add_rule is redundant. In that case, for symmetry I think we should also return after calling set_context_path as well.