Add some more integral functions #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks similar to a77c08e. I was meaning to make a PR but didn't get round to it. |
| >> Erf[0] | ||
| = 0 | ||
| >> Plot[Erf[x], {x, -2, 2}] | ||
| = -Graphics- |
There was a problem hiding this comment.
These should be InverseErf not Erf.
|
Happy to rebase this on a77c08e if you like? Didn't realise you were already looking at this! There are some tests in that commit that I think it'd be good to have. |
|
I think it's fine not to rebase. Feel free to copy the tests if you think they're useful. I am working on fixing some precision issues related to |
Gamma with two inexact arguments tried to call mpmath's gamma function which only accepts one argument.
These were taken from commit a77c08e.
bnjones
force-pushed
the
integral-functions
branch
from
c4e33a6 to
9cbe8d6
Compare
|
Looks good 👍 , anything more to add? |
|
Great, thanks for the review! Still got a few (small) things to add, I'll push these shortly. |
Slight simplification since Log is the only builtin overriding it.
bnjones
changed the title
|
Shall I merge this? |
|
Yep, if you're happy with it I'm happy with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still to do:
_MPMathFunctionto support dispatching to multiple mpmath functionsErfInverseErf