a basic version of Nearest[] #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sn6uv
reviewed
Sep 17, 2016
| candidates = heapq.nsmallest(py_n, py_distances) | ||
|
|
||
| for d, i in candidates: | ||
| if py_r is not None and d > py_r: |
There was a problem hiding this comment.
I think we should filter before finding the py_n smallest:
- Avoids comparison with
Nonein heapq.nsmallest - If k elements are within the limit distance the runtime is (very) slightly better: O(n) + O(min(k, m) log(k)) vs O(m log (n)) for m nearest elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the
Scanmethod is implemented here, but it's still quite useful, I think.