-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Support for Celltotex #995
Conversation
"`*" is the same as "*`*" - is this right?
I love this idea! I can find a number of other packages including some of the ones mentioned at sagemath that basically use the same kind of install mechanism. I bet https://github.com/jkuczm/MathematicaSyntaxAnnotations#no-installation would be another one that would work because it outside of the install mechanism what's going on is pretty straightforward. Maybe after this is done we can come up with a list of packages that can be installed this way and mention that in the repository somewhere. |
Status update: several bugs and implementation issues on the Package and context subsystems were fixed. |
I added a line looking if the Import was successful. If it is, it performs the test. An improvement would be to raise a warning when this happens. The problem with flaky and pytest.skipif is that I would need to know (ahead) if there is an internet connection, and the package is available. @rocky , if you can give me a hand with the part of testing, I can continue with the fixings for the interpreter. |
Sure. Over the weekend I can add some commits in a branch off of this that you can look at. |
Update: I found and fixed some issues with Systemp`Protect. Also, I included some support for DeleteCases with the levelspect parameter, and n. Still does not work, but now the number of errors is smaller... |
Thanks for undertaking this. Being able to do some sort of import of simple packages is very important. I am guessing that after this is done there will be many many more packages that we will be able to load which will add both power to Mathics and help draw in a community using and working on Mathics. |
Just curious, How close is this to working? I also wonder what our chances are for importing other things of this kind are now? |
Well, I am not sure when this package is going to work, but in the way I think we have improved a lot the support for the existing symbols. At this point, it seems that there are not fails in the import process, but for some reason, it still fails when the main routines are called. I hope to have more time during the next weeks to continue with this. |
It might be good to break this PR up into little pieces that work and get that merged into master. |
Actually, I did it and a couple of them were already merged. The remaining, working changes are in #1088 |
@@ -26,7 +28,11 @@ Enhancements and Bug fixes: | |||
|
|||
- Fix evaluation timeouts | |||
- ``Sum``'s lower and upper bounds values can now be Mathics expressions | |||
|
|||
- Support for ``All`` as a ``Part`` espeficication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmatera It would be good to merge this into master.
- Support for ``All`` as a ``Part`` espeficication | ||
- Fix BeginPackage | ||
- Improving support for OptionValue. Not it support list of Options. | ||
- Adding support in ``from_python()`` to convert dictionaries in list of rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmatera It would also be good to get this into master
@@ -629,7 +631,7 @@ class BeginPackage(Builtin): | |||
Append[System`Private`$ContextPathStack, $ContextPath]; | |||
$ContextPath = {context, "System`"}; | |||
$Packages = If[MemberQ[System`$Packages,$Context], | |||
None, | |||
$Packages, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've run into this problem a bit too, so it might be good to get this into master.
…nto celltotexfixes
In this branch, I am trying to include all the fixes needed to make that CellsToTeX package
Import@"https://raw.githubusercontent.com/jkuczm/MathematicaCellsToTeX/master/NoInstall.m"
This involves improvements in WL native Patterns support, Protect/Unprotect mechanisms, Names[], etc. The idea would be to merge this branch when the Import stops showing errors, including adding some tests.