Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I define an explicit include, it should take precedence over default excludes #143

Closed
beamerblvd opened this issue Jan 23, 2019 · 0 comments
Assignees
Milestone

Comments

@beamerblvd
Copy link

I added this to my pom.xml:

<includes>
    <include>**/.travis.yml</include>
</includes>
<mapping>
    ...
    <yaml>SCRIPT_STYLE</yaml>
    <yml>SCRIPT_STYLE</yml>
</mapping>

...because I specifically DO want that file to contain a copyright header. However, because **/.travis.yml is in the default excludes, it is excluded no matter what I do. I could disable useDefaultExcludes, but then I would have to re-define the 150+ other valid excludes that I want to keep which is not an option for me. So, for now, I'm having to manually manage headers in .travis.yml files. I also tried .travis.yml instead of **/.travis.yml to no avail.

<includes> should take precedence over the default excludes:

Implementation Option 1: Anything in <includes> that matches a file equally or more precisely than a default exclude should override that default exclude.
Implementation Option 2: Anything in <includes> that exactly matches an entry in the default excludes should disable that one default exclude.

@ghost ghost assigned mathieucarbou Feb 6, 2019
@ghost ghost added the under-review label Feb 6, 2019
@mathieucarbou mathieucarbou added this to the 4.0 milestone Feb 6, 2019
mathieucarbou added a commit that referenced this issue Feb 6, 2019
Fix #143: Add ability to override a default exclusion to include a pattern from the latter
@ghost ghost removed the under-review label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants