feature: Add a numberThreads parameter.
#133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a parameter to specify an absolute value of threads to start. For the rational please see mathieucarbou#132
ghost
assigned 
mathieucarbou
requested changes
Feb 1, 2019
sic2
reviewed
Feb 1, 2019
| * The default is 0 which implies that the default for <code>concurrencyFactor</code> | ||
| * is used. | ||
| */ | ||
| @Parameter(property = "license.numberThreads", defaultValue = "0") |
|
|
||
| private int getNumberOfExecutorThreads() { | ||
| int nThreads = numberThreads; | ||
| if (nThreads != 0) { |
There was a problem hiding this comment.
are you validating against negative numbers?
|
Replaced by #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter to specify an absolute value of threads to start.
For the rational please see #132
Please choose either #132 or this PR, they are orthogonal and this PR includes also the fix of #132.