Track the year of a file creation through license-maven-plugin-git #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason behind this PR: Sometimes you are required to include in your license header only the date of the file creation. These changes allow us to look at the git history and find the year of reation for a given file. Note: Sometimes git is unable to figure out the date of creation of a file if this has moved/renamed without git being able to detect such change. A potential future solution could be to avoid dates to be overwritten. I would leave that for another PR though. Additionally, this PR reduces a bit of duplicated code in the git plugin.
ghost
assigned 
|
@mathieucarbou I opened a new PR since I had setup that wrong being it in the master branch of my fork. |
mathieucarbou
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason behind this PR:
Sometimes you are required to include in your license header only the
date of the file creation.
These changes allow us to look at the git history and find the year of
reation for a given file.
Note:
Sometimes git is unable to figure out the date of creation of a file if
this has moved/renamed without git being able to detect such change.
A potential future solution could be to avoid dates to be overwritten.
I would leave that for another PR though.
Additionally, this PR reduces a bit of duplicated code in the git plugin.